linux-kernel - Re: [net-next PATCH v3 3/6] octeontx2-pf: AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49043623-f34e-4274-ab4d-494d8319cb32@redhat.com>
Date: Tue, 14 Jan 2025 13:46:48 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Suman Ghosh <sumang@...vell.com>, horms@...nel.org, sgoutham@...vell.com,
 gakula@...vell.com, sbhatta@...vell.com, hkelam@...vell.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, lcherian@...vell.com,
 jerinj@...vell.com, john.fastabend@...il.com, bbhushan2@...vell.com,
 hawk@...nel.org, andrew+netdev@...n.ch, ast@...nel.org,
 daniel@...earbox.net, bpf@...r.kernel.org
Subject: Re: [net-next PATCH v3 3/6] octeontx2-pf: AF_XDP zero copy receive
 support

On 1/10/25 10:38 AM, Suman Ghosh wrote:
> @@ -1337,8 +1358,12 @@ void otx2_aura_pool_free(struct otx2_nic *pfvf)
>  		pool = &pfvf->qset.pool[pool_id];
>  		qmem_free(pfvf->dev, pool->stack);
>  		qmem_free(pfvf->dev, pool->fc_addr);
> -		page_pool_destroy(pool->page_pool);
> -		pool->page_pool = NULL;
> +		if (pool->page_pool) {
> +			page_pool_destroy(pool->page_pool);
> +			pool->page_pool = NULL;
> +		}

It looks like the above delta is not needed: page_pool_destroy() handles
correctly NULL value for the page pool.

/P