linux-kernel - Re: [PATCH 4/4] arm64: dts: renesas: Add initial device tree for Yuridenki-Shokai Kakip board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABMQnVKhwQnRwNEvMeAXx3LLA-HhJN-s0QCJmzJxwowbUhD1-Q@mail.gmail.com>
Date: Tue, 14 Jan 2025 22:34:11 +0900
From: Nobuhiro Iwamatsu <iwamatsu@...auri.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Masato Kiuchi <kiuchi_masato@...idenki.co.jp>
Subject: Re: [PATCH 4/4] arm64: dts: renesas: Add initial device tree for
 Yuridenki-Shokai Kakip board

Hi,

Thanks for your review.

2025年1月11日(土) 18:34 Krzysztof Kozlowski <krzk@...nel.org>:
>
> On 11/01/2025 09:09, Nobuhiro Iwamatsu wrote:
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
> > @@ -0,0 +1,138 @@
> > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +/*
> > + * Device Tree Source for Yuridenki-Shokai the Kakip board
> > + *
> > + * Copyright (C) 2024 Nobuhiro Iwamatsu <iwamatsu@...auri.org>
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include <dt-bindings/pinctrl/renesas,r9a09g057-pinctrl.h>
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include "r9a09g057.dtsi"
> > +
> > +/ {
> > +     model = "Yuridenki-Shokai Kakip Board based on r9a09g057h48";
> > +     compatible = "yuridenki,kakip", "renesas,r9a09g057h48", "renesas,r9a09g057";
> > +
> > +     aliases {
> > +             serial0 = &scif;
> > +             mmc0 = &sdhi0;
> > +     };
> > +
> > +     chosen {
> > +             bootargs = "ignore_loglevel";
>
> Not really suitable for mainline DTS. This is just debugging, so drop.
> Just like earlycon - not suitable for mainline usage.

OK, I will drop this.
>
> > +             stdout-path = "serial0:115200n8";
> > +     };
> > +
> > +     memory@...00000 {
> > +             device_type = "memory";
> > +             /* first 128MB is reserved for secure area. */
> > +             reg = <0x0 0x48000000 0x1 0xF8000000>;
> > +     };
> > +
> > +     reg_3p3v: regulator1 {
>
> Keep consistent naming. regulator-1 or the name as in bindings:
> 'regulator-[0-9]v[0-9]'
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46
>

Thanks, I will fix naming and use regulator-*.

> > +             compatible = "regulator-fixed";
> > +
> > +             regulator-name = "fixed-3.3V";
> > +             regulator-min-microvolt = <3300000>;
> > +             regulator-max-microvolt = <3300000>;
> > +             regulator-boot-on;
> > +             regulator-always-on;
> > +     };
> > +
> > +     vqmmc_sdhi0: regulator-vccq-sdhi0 {
>
> regulator-2? Why different styles of names?
>
> > +             compatible = "regulator-gpio";
> > +             regulator-name = "SDHI0 VccQ";
> > +             gpios = <&pinctrl RZV2H_GPIO(A, 0) GPIO_ACTIVE_HIGH>;
> > +             regulator-min-microvolt = <1800000>;
> > +             regulator-max-microvolt = <3300000>;
> > +             gpios-states = <0>;
> > +             states = <3300000 0 1800000 1>;
> > +     };
> > +};
> > +
> > +&qextal_clk {
> > +     clock-frequency = <24000000>;
> > +};
> > +
> > +&pinctrl {
> > +     scif_pins: scif {
> > +             pins =  "SCIF_RXD", "SCIF_TXD";
> > +     };
> > +
> > +     sd0-pwr-en-hog {
> > +             gpio-hog;
> > +             gpios = <RZV2H_GPIO(A, 1) GPIO_ACTIVE_HIGH>;
> > +             output-high;
> > +             line-name = "sd0_pwr_en";
> > +     };
> > +
> > +     sdhi0_pins: sd0 {
> > +             sd0_data {
>
>
> No underscores in node names. Please follow DTS coding style.
>

OK, I will fix these.

>
> Best regards,
> Krzysztof

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 32247FBB40AD1FA6