linux-kernel - Re: [PATCH v2] pinctrl: amd: Take suspend type into consideration which pins are non-wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZVihBHrYEEq+_-X9HstKsN0x_RWjUmLm68Q3B=6d+Dvg@mail.gmail.com>
Date: Tue, 14 Jan 2025 14:35:16 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc: Basavaraj Natikar <Basavaraj.Natikar@....com>, Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
	Mario Limonciello <mario.limonciello@....com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: amd: Take suspend type into consideration
 which pins are non-wake

On Mon, Jan 6, 2025 at 6:41 PM Maciej S. Szmigiero
<mail@...iej.szmigiero.name> wrote:

> Some laptops have pins which are a wake source for S0i3/S3 but which
> aren't a wake source for S4/S5 and which cause issues when left unmasked
> during hibernation (S4).
>
> For example HP EliteBook 855 G7 has pin #24 that causes instant wakeup
> (hibernation failure) if left unmasked (it is a wake source only for
> S0i3/S3).
> GPIO pin #24 on this platform is likely dedicated to WWAN XMM7360
> modem since this pin triggers wake notify to WWAN modem's parent PCIe
> port.
>
> Fix this by considering a pin a wake source only if it is marked as one
> for the current suspend type (S0i3/S3 vs S4/S5).
>
> Since Z-wake pins only make sense at runtime these were excluded from
> both of suspend categories, so pins with only the Z-wake flag set are
> effectively treated as non-wake pins.
>
> Fixes: 2fff0b5e1a6b ("pinctrl: amd: Mask non-wake source pins with interrupt enabled at suspend")
> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>

Patch applied!
Right now it will be for the merge window (v6.14-rc1) but you can
ask the stable maintainers to backport it, sometimes they pick
patches with a Fixes: tag on their own.

Yours,
Linus Walleij