linux-kernel - Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <003b6048-eb38-4bbc-8c83-31d45f0db46d@kernel.org>
Date: Tue, 14 Jan 2025 14:39:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>, marcel@...tmann.org,
 luiz.dentz@...il.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, amitkumar.karwar@....com, sherry.sun@....com,
 ziniu.wang_1@....com, johan.korsnes@...arkable.no,
 kristian.krohn@...arkable.no, manjeet.gupta@....com
Subject: Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support to
 set BD address

On 14/01/2025 14:35, Neeraj Sanjay Kale wrote:
> This adds a new optional device tree property local-bd-address to allow

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> user to set custom BD address for NXP chipsets.


> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> ---
> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
> --- 
>  .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 0a2d7baf5db3..5d75a45cac14 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -17,6 +17,9 @@ description:
>  maintainers:
>    - Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
>  
> +allOf:
> +  - $ref: bluetooth-controller.yaml#
> +
>  properties:
>    compatible:
>      enum:
> @@ -40,10 +43,12 @@ properties:
>        Host-To-Chip power save mechanism is driven by this GPIO
>        connected to BT_WAKE_IN pin of the NXP chipset.
>  
> +  local-bd-address: true

In case I was not clear: drop. And rephrase the commit msg to reflect this.

Best regards,
Krzysztof