linux-kernel - Re: [PATCH v1 1/2] riscv: dts: starfive: jh7110: pciephy0 USB 3.0 configuration registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SHXPR01MB0863DBF85A9874C9F93ECD25E618A@SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn>
Date: Tue, 14 Jan 2025 05:42:28 +0000
From: Minda Chen <minda.chen@...rfivetech.com>
To: Conor Dooley <conor@...nel.org>, E Shattow <e@...eshell.de>
CC: Emil Renner Berthing <kernel@...il.dk>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Paul Walmsley
	<paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	<aou@...s.berkeley.edu>, "linux-riscv@...ts.infradead.org"
	<linux-riscv@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/2] riscv: dts: starfive: jh7110: pciephy0 USB 3.0
 configuration registers



> 
> On Thu, Jan 02, 2025 at 10:37:36AM -0800, E Shattow wrote:
> > StarFive JH7110 contains a Cadence USB2.0+USB3.0 controller IP block
> > that may exclusively use pciephy0 for USB3.0 connectivity. Add the
> > register offsets for the driver to enable/disable USB3.0 on pciephy0.
> >
> > Signed-off-by: E Shattow <e@...eshell.de>
> > ---
> >  arch/riscv/boot/dts/starfive/jh7110.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> > b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> > index 0d8339357bad..75ff07303e8b 100644
> > --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> > +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> > @@ -611,6 +611,8 @@ usbphy0: phy@...00000 {
> >  		pciephy0: phy@...10000 {
> >  			compatible = "starfive,jh7110-pcie-phy";
> >  			reg = <0x0 0x10210000 0x0 0x10000>;
> > +			starfive,sys-syscon = <&sys_syscon 0x18>;
> > +			starfive,stg-syscon = <&stg_syscon 0x148 0x1f4>;
> 
> Why weren't these added in the first place? Minda, do you know?
> 
The driver only require to set syscon register while the PHY attach to Cadence USB.(star64 board case)
The PHY default attach to PCIe0, VF2 board do not set any setting. So I don't set it.
> >  			#phy-cells = <0>;
> >  		};
> >
> > --
> > 2.45.2
> >