linux-kernel - [PATCH] scsi: ufs: core: increase the NOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250115022344.3967-1-dh0421.hwang@samsung.com>
Date: Wed, 15 Jan 2025 11:23:44 +0900
From: DooHyun Hwang <dh0421.hwang@...sung.com>
To: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	alim.akhtar@...sung.com, avri.altman@....com, bvanassche@....org,
	James.Bottomley@...senPartnership.com, martin.petersen@...cle.com,
	peter.wang@...iatek.com, manivannan.sadhasivam@...aro.org,
	quic_mnaresh@...cinc.com
Cc: grant.jung@...sung.com, jt77.jang@...sung.com, junwoo80.lee@...sung.com,
	jangsub.yi@...sung.com, sh043.lee@...sung.com, cw9316.lee@...sung.com,
	sh8267.baek@...sung.com, wkon.kim@...sung.com, DooHyun Hwang
	<dh0421.hwang@...sung.com>
Subject: [PATCH] scsi: ufs: core: increase the NOP_OUT command timeout

It is found that is UFS device may take longer than 500ms(50ms * 10times)
to respond to NOP_OUT command.

The NOP_OUT command timeout was total 500ms that is from
a timeout value of 50ms(defined by NOP_OUT_TIMEOUT)
with 10 retries(defined by NOP_OUT_RETRIES)

This change increase the NOP_OUT command timeout to total 1000ms
by changing timeout value to 100ms(NOP_OUT_TIMEOUT)

Signed-off-by: DooHyun Hwang <dh0421.hwang@...sung.com>
---
 drivers/ufs/core/ufshcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index cd404ade48dc..bf5c4620ef6b 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -57,8 +57,8 @@ enum {
 };
 /* NOP OUT retries waiting for NOP IN response */
 #define NOP_OUT_RETRIES    10
-/* Timeout after 50 msecs if NOP OUT hangs without response */
-#define NOP_OUT_TIMEOUT    50 /* msecs */
+/* Timeout after 100 msecs if NOP OUT hangs without response */
+#define NOP_OUT_TIMEOUT    100 /* msecs */
 
 /* Query request retries */
 #define QUERY_REQ_RETRIES 3
-- 
2.48.0