linux-kernel - RE: [RESEND PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134DEA89B78F45AA20C1C2E89192@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Wed, 15 Jan 2025 13:45:52 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Nikolay Borisov <nik.borisov@...e.com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>
CC: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "bp@...en8.de" <bp@...en8.de>
Subject: RE: [RESEND PATCH 3/3] x86/mce: Make mce_notify_irq() depend on
 CONFIG_X86_MCELOG_LEGACY

> From: Nikolay Borisov <nik.borisov@...e.com>
> Sent: Wednesday, January 15, 2025 3:37 PM
> To: linux-edac@...r.kernel.org
> Cc: x86@...nel.org; linux-kernel@...r.kernel.org; bp@...en8.de; Nikolay
> Borisov <nik.borisov@...e.com>
> Subject: [RESEND PATCH 3/3] x86/mce: Make mce_notify_irq() depend on
> CONFIG_X86_MCELOG_LEGACY
> 
> mce_notify_irq() really depends on the legacy mcelog being enabled as
> otherwise mce_work_trigger() will never schedule the trigger work as
> mce_helper can't be set unless CONFIG_X86_MCELOG_LEGACY is defined.
> 
> Signed-off-by: Nikolay Borisov <nik.borisov@...e.com>
> ---
>  arch/x86/kernel/cpu/mce/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
> index 89625ff79c3b..b21aa1494da0 100644
> --- a/arch/x86/kernel/cpu/mce/core.c
> +++ b/arch/x86/kernel/cpu/mce/core.c
> @@ -591,6 +591,7 @@ EXPORT_SYMBOL_GPL(mce_is_correctable);
>   */
>  static int mce_notify_irq(void)
>  {
> +#ifdef CONFIG_X86_MCELOG_LEGACY
>  	/* Not more than two messages every minute */
>  	static DEFINE_RATELIMIT_STATE(ratelimit, 60*HZ, 2);
> 
> @@ -602,7 +603,7 @@ static int mce_notify_irq(void)
> 

The message printed inside this function should not depend on 
CONFIG_X86_MCELOG_LEGACY.  User-space tools/scripts might look for this
message to detect machine events. It is also useful for debugging purposes.

   if (__ratelimit(&ratelimit))
       pr_info(HW_ERR "Machine check events logged\n");

>  		return 1;
>  	}
> -
> +#endif
>  	return 0;
>  }
> 
> --
> 2.43.0
>