linux-kernel - Re: [PATCH v6] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250115100547.63dec2d7@gandalf.local.home>
Date: Wed, 15 Jan 2025 10:05:47 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Lukas Wunner <lukas@...ner.de>
Cc: Shuai Xue <xueshuai@...ux.alibaba.com>, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, helgaas@...nel.org,
 bhelgaas@...gle.com, tony.luck@...el.com, bp@...en8.de,
 mhiramat@...nel.org, mathieu.desnoyers@...icios.com, oleg@...hat.com,
 naveen@...nel.org, davem@...emloft.net, anil.s.keshavamurthy@...el.com,
 mark.rutland@....com, peterz@...radead.org, tianruidong@...ux.alibaba.com
Subject: Re: [PATCH v6] PCI: hotplug: Add a generic RAS tracepoint for
 hotplug event

On Wed, 15 Jan 2025 10:33:39 +0100
Lukas Wunner <lukas@...ner.de> wrote:

> > > 
> > > 	TP_STRUCT__entry(
> > > 		__string(	port_name,	pci_name(ctrl->pcie->port)	)
> > > 		__string(	slot,		slot_name(ctrl)			)
> > > 		__field(	int,		event				)
> > > 
> > > and everything else could be the same.  
> > 
> > Maybe it's not a good idea.
> > 
> > I think pci_hp_event is a generic event for pciehp, shpchp, octep_hp, etc.
> > But each hotplug driver has different `struct controller` and slot_name().  
> [...]
> > So, IMHO, pass port_name and slot_name from each driver is more simple.
> > 
> > + @Lukas for hotplug part.  
> 
> You're right Shuai, there's several hotplug drivers in drivers/pci/hotplug/
> and pciehp is just one of them.  It's quite possible that other drivers
> besides pciehp will want to add trace points as well.  For consistency,
> the trace event definitions need to work for all drivers.

OK, if this is a generic trace event then it does make sense sending in the
names instead of the structure.

-- Steve