linux-kernel - Re: [PATCH v7 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250115023018.15353-1-amadeus@jmu.edu.cn>
Date: Wed, 15 Jan 2025 10:30:18 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: bigfoot@...ssfun.cn
Cc: devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	Chukun Pan <amadeus@....edu.cn>
Subject: Re: [PATCH v7 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

Hi,
> [1] https://github.com/photonicat/rockchip_rk3568_kernel/blob/novotech-5.10/arch/arm64/boot/dts/rockchip/rk3568-photonicat-base.dtsi

I don't think this link has reference value. I was misled
by this several times when I wrote dts before.

> +&pcie3x2 {
> +	max-link-speed = <1>;
> +	num-lanes = <1>;

I'm not sure about this.
This PCIe3.0 x2 is not split.

> +&sdmmc1 {
> ...
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_cmd &sdmmc1_clk>;

pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_clk &sdmmc1_cmd>;

> +	wifi: wifi@1 {
> +		reg = <1>;

No aliases needed.
Other parts LGTM.

-- 
2.25.1