linux-kernel - Re: [PATCH] cpumask: Rephrase comments for cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4faYaMwHymIWdps@thinkpad>
Date: Wed, 15 Jan 2025 10:55:13 -0500
From: Yury Norov <yury.norov@...il.com>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: I Hsin Cheng <richard120310@...il.com>, linux@...musvillemoes.dk,
	linux-kernel@...r.kernel.org, jserv@...s.ncku.edu.tw,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] cpumask: Rephrase comments for cpu_any*() APIs

On Wed, Jan 15, 2025 at 08:55:50PM +0800, Kuan-Wei Chiu wrote:
> On Wed, Jan 15, 2025 at 03:19:32PM +0800, I Hsin Cheng wrote:
> > The cpu_any*() APIs comment states that it returns a "random" cpu within
> > the given cpumask. Hoever it's not actually random as random itself
> 
> s/Hoever/However

Hi I Hsin,

Can you please fix this typo, drop quotes around the 'arbitrary' word,
as suggested by Mark, and send v2?

Please also keep Mark in the loop.

Thanks,
Yury

> 
> > stands a meaning for uniform distribution.
> > 
> > cpu_any*() APIs are a naming convention for the caller to states that it
> > doesn't care which CPU it gets, so change "random" to "arbitrary" would
> > be more appropriate.
> > 
> > Signed-off-by: I Hsin Cheng <richard120310@...il.com>
> 
> With the above corrections:
> 
> Reviewed-by: Kuan-Wei Chiu <visitorckw@...il.com>
> 
> Regards,
> Kuan-Wei