linux-kernel - Re: [PATCH v3] ALSA: hda: Support for Ideapad hotkey mute LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874j20jcdd.wl-tiwai@suse.de>
Date: Wed, 15 Jan 2025 17:00:30 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Jackie Dong <xy-jackie@....com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	bo.liu@...arytech.com,
	kovalev@...linux.org,
	me@...herl.one,
	jaroslaw.janik@...il.com,
	songxiebing@...inos.cn,
	cs@...edo.de,
	kailang@...ltek.com,
	sbinding@...nsource.cirrus.com,
	simont@...nsource.cirrus.com,
	josh@...huagrisham.com,
	rf@...nsource.cirrus.com,
	linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	dongeg1@...ovo.com,
	Mark Pearson <mpearson-lenovo@...ebb.ca>
Subject: Re: [PATCH v3] ALSA: hda: Support for Ideapad hotkey mute LEDs

On Wed, 15 Jan 2025 16:48:11 +0100,
Jackie Dong wrote:
> 
> 
> New ideapad helper file with support for handling FN key mute LEDs.
> Update conexant and realtec codec to add LED support.
> 
> Suggested-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> Signed-off-by: Jackie Dong  <xy-jackie@....com>

It's almost fine, just one minor thing:

> @@ -11130,6 +11146,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>  	{.id = ALC290_FIXUP_MONO_SPEAKERS_HSJACK, .name = "mono-speakers"},
>  	{.id = ALC290_FIXUP_SUBWOOFER_HSJACK, .name = "alc290-subwoofer"},
>  	{.id = ALC269_FIXUP_THINKPAD_ACPI, .name = "thinkpad"},
> +	{.id = ALC269_FIXUP_LENOVO_XPAD_ACPI, .name = "lenovo xpad led"},

The model string shouldn't contain a space.  It'd be too difficult to
specify in the boot option.  Use a hyphen instead.


thanks,

Takashi