linux-kernel - Re: [PATCH v3 1/2] dt-bindings: rtc: max31335: Add max31331 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8d6117a-d48f-440e-a6b1-9770bf5fbc9f@kernel.org>
Date: Wed, 15 Jan 2025 17:07:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "U, Pavithra" <Pavithra.U@...log.com>
Cc: "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jean Delvare <jdelvare@...e.com>,
 Guenter Roeck <linux@...ck-us.net>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: rtc: max31335: Add max31331 support

On 15/01/2025 11:21, U, Pavithra wrote:
>>>
>>>    interrupts:
>>>      maxItems: 1
>>> @@ -57,9 +60,9 @@ examples:
>>>          #address-cells = <1>;
>>>          #size-cells = <0>;
>>>
>>> -        rtc@68 {
>>> +        rtc@69 {
>>>              compatible = "adi,max31335";
>>> -            reg = <0x68>;
>>> +            reg = <0x69>;
>>
>> Why? I already asked about this - the same question "Why"
> 
> While testing, it was identified that the i2c address for max31335 is 0x69. Sorry, I will revert and send the fix in a separate patch.

Yes, please.



Best regards,
Krzysztof