linux-kernel - Re: [PATCH linux-next v1] PCI: rockchip: Improve error handling in clock return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANAwSgQ2-r5gHmNwf9YTWXEU-mQ6dVpjFV4gzM+sVGsTUit7ew@mail.gmail.com>
Date: Wed, 15 Jan 2025 23:52:33 +0530
From: Anand Moon <linux.amoon@...il.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Shawn Lin <shawn.lin@...k-chips.com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kw@...ux.com>, 
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Heiko Stuebner <heiko@...ech.de>, 
	Dan Carpenter <dan.carpenter@...aro.org>, linux-pci@...r.kernel.org, 
	linux-rockchip@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next v1] PCI: rockchip: Improve error handling in
 clock return value

Hi Mani/ Bjon,

On Wed, 15 Jan 2025 at 23:18, Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Wed, Jan 15, 2025 at 11:10:12PM +0530, Manivannan Sadhasivam wrote:
> > On Mon, Jan 06, 2025 at 09:00:38PM +0530, Anand Moon wrote:
> >
> > Subject should include the word 'fix' not 'improve'
> >
> > > Updates the error message to include the actual return value of
> >
> > s/Updates/Update (imperative form)
> >
> > > devm_clk_bulk_get_all, which provides more context for debugging
> > > and troubleshooting the root cause of clock retrieval failures.
> >
> > Btw, it is not just updating the error message, it also returns the
> > actual error code.
correct.
>
> Already squashed into
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?id=abdd4c8ea7d7,
> sorry I didn't mention that here.
>
Thanks,

I will focus on improving my communication skills and delivering impactful
commit messages in the future.

Thank
-Anand