linux-kernel - Re: [PATCH] riscv: Add initial Xen guest support for RISC-V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKp59VHBLtpxk7MD3StO8v8M5vdqbWU7AZaoxukzYPFCmSF91w@mail.gmail.com>
Date: Wed, 15 Jan 2025 19:26:03 +0100
From: Milan Đokić <milandjokic1995@...il.com>
To: Teddy Astie <teddy.astie@...es.tech>
Cc: linux-riscv@...ts.infradead.org, paul.walmsley@...ive.com, 
	palmer@...belt.com, aou@...s.berkeley.edu, jgross@...e.com, 
	sstabellini@...nel.org, oleksandr_tyshchenko@...m.com, 
	Slavisa.Petrovic@...rk.com, Milan.Djokic@...rk.com, 
	rafael.j.wysocki@...el.com, sunilvl@...tanamicro.com, takakura@...inux.co.jp, 
	linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org, 
	iommu@...ts.linux.dev
Subject: Re: [PATCH] riscv: Add initial Xen guest support for RISC-V

Hello Teddy,

On Tue, Jan 14, 2025 at 6:51 PM Teddy Astie <teddy.astie@...es.tech> wrote:
>
> Le 14/01/2025 à 17:13, Milan Djokic a écrit :
> > diff --git a/test.txt b/test.txt
> > new file mode 100644
> > index 000000000000..e54267998982
> > --- /dev/null
> > +++ b/test.txt
> > @@ -0,0 +1,21 @@
> > +WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > +#120:
> > +new file mode 100644
> > +
> > +WARNING: do not add new typedefs
> > +#808: FILE: include/xen/riscv/interface.h:15:
> > ++    typedef struct { union { type * p; uint64_aligned_t q; }; }  \
> > +
> > +WARNING: please, no spaces at the start of a line
> > +#1006: FILE: include/xen/riscv/swiotlb-xen.h:10:
> > ++    return 0;$
> > +
> > +total: 0 errors, 3 warnings, 810 lines checked
> > +
> > +NOTE: For some of the reported defects, checkpatch may be able to
> > +      mechanically convert to the typical style using --fix or --fix-inplace.
> > +
> > +0001-riscv-Add-initial-Xen-guest-support-for-RISC-V.patch has style problems, please review.
> > +
> > +NOTE: If any of the errors are false positives, please report
> > +      them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> I am not sure you want this here.
>
Sorry, this one is added by accident. Will be removed.

>  > diff --git a/arch/riscv/include/asm/hypervisor.h
> b/arch/riscv/include/> asm/hypervisor.h
>  > new file mode 100644
>  > index 000000000000..3a117afe57f0
>  > --- /dev/null
>  > +++ b/arch/riscv/include/asm/hypervisor.h
>  > @@ -0,0 +1,9 @@
>  > +/* SPDX-License-Identifier: GPL-2.0 */
>  > +#ifndef _ASM_RISCV_HYPERVISOR_H
>  > +#define _ASM_RISCV_HYPERVISOR_H
>  > +
>  > +#include <asm/xen/hypervisor.h>
>  > +
>  > +void kvm_init_hyp_services(void);
>  > +
>  > +#endif
>
> kvm_init_hyp_services seems KVM-specific and doesn't seem to exist (yet)
> for RISC-V.
>
Yes, we'll remove it in the next revision.

BR,
Milan