linux-kernel - RE: [EXTERNAL] Re: [net-next PATCH v3 3/6] octeontx2-pf: AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ0PR18MB52164594C0C0C24C0AD50C71DB192@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Wed, 15 Jan 2025 18:31:22 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Paolo Abeni <pabeni@...hat.com>, "horms@...nel.org" <horms@...nel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Linu Cherian <lcherian@...vell.com>, Jerin
 Jacob <jerinj@...vell.com>,
        "john.fastabend@...il.com"
	<john.fastabend@...il.com>,
        Bharat Bhushan <bbhushan2@...vell.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v3 3/6] octeontx2-pf: AF_XDP zero
 copy receive support

>> @@ -1337,8 +1358,12 @@ void otx2_aura_pool_free(struct otx2_nic *pfvf)
>>  		pool = &pfvf->qset.pool[pool_id];
>>  		qmem_free(pfvf->dev, pool->stack);
>>  		qmem_free(pfvf->dev, pool->fc_addr);
>> -		page_pool_destroy(pool->page_pool);
>> -		pool->page_pool = NULL;
>> +		if (pool->page_pool) {
>> +			page_pool_destroy(pool->page_pool);
>> +			pool->page_pool = NULL;
>> +		}
>
>It looks like the above delta is not needed: page_pool_destroy() handles
>correctly NULL value for the page pool.
[Suman] ack, will update in v4
>
>/P