linux-kernel - Re: [PATCH v4 01/11] mtd: core: always create master device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871px3lw5q.fsf@bootlin.com>
Date: Wed, 15 Jan 2025 20:22:25 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Usyskin, Alexander" <alexander.usyskin@...el.com>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  "De Marchi, Lucas" <lucas.demarchi@...el.com>,  Thomas
 Hellström <thomas.hellstrom@...ux.intel.com>,  "Vivi,
 Rodrigo"
 <rodrigo.vivi@...el.com>,  Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>,  Maxime Ripard <mripard@...nel.org>,
  Thomas Zimmermann <tzimmermann@...e.de>,  David Airlie
 <airlied@...il.com>,  Simona Vetter <simona@...ll.ch>,  Jani Nikula
 <jani.nikula@...ux.intel.com>,  Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>,  Tvrtko Ursulin <tursulin@...ulin.net>,
  "Poosa, Karthik" <karthik.poosa@...el.com>,  "Abliyev, Reuven"
 <reuven.abliyev@...el.com>,  "Weil, Oren jer" <oren.jer.weil@...el.com>,
  "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
  "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
  "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 01/11] mtd: core: always create master device

Hi,


On 14/01/2025 at 14:05:40 GMT, "Usyskin, Alexander" <alexander.usyskin@...el.com> wrote:

>> > > Create master device without partition when
>> > > CONFIG_MTD_PARTITIONED_MASTER flag is unset.
>> >
>> > I don't think you took into consideration my remarks regarding the fact
>> > that you would break userspace. If you enable the master, you no longer
>> > have the same device numbering in userspace. I know people should not
>> > care about these numbers, but in practice they do.
>> >
>> > If I'm wrong, please be a little more verbose about why :)
>> >
>> > Thanks,
>> > Miquèl
>> 
>> Hi Miquel
>> 
>> I've created separate class (mtd_master) for such devices.
>> Uses-space looking for mtd device continues to receive same number of
>> /dev/mtdX devices.
>> There will be additional /dev/mtd_masterX devices, but this is unavoidable, I
>> suppose.
>> Maybe we can rename it to something that not in /dev/mtd* expression (e.g.
>> mastermtdX),
>> if it helps.
>> 
>
> Miquel, is this good enough or requires rewrite?

This is an important change that requires attention, and at the time I
have not been able to dedicate enough to this patch.

Also, if the other mtd maintainers want to help, I'll be enthousiastic
about it :)

Thanks,
Miquèl