linux-kernel - Re: [PATCH] spi: microchip-core: prevent RX overflows when transmit size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40aecf85-1d30-464f-bd67-59eb8fc62700@sirena.org.uk>
Date: Wed, 15 Jan 2025 19:33:24 +0000
From: Mark Brown <broonie@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: linux-spi@...r.kernel.org, Conor Dooley <conor.dooley@...rochip.com>,
	stable@...r.kernel.org,
	Daire McNamara <daire.mcnamara@...rochip.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: microchip-core: prevent RX overflows when transmit
 size > FIFO size

On Wed, Jan 15, 2025 at 06:22:55PM +0000, Conor Dooley wrote:

> Moving it out of the interrupt handler entirely probably makes the code
> a lot easier to reason about, so I think I'd actually rather do that.
> That said, I don't think I would want that change going into fixes as it's
> a pretty intrusive change, although given where we are in the cycle it
> ain't as much of a problem since I'd not be sending it until after 6.13
> is released anyway.

OTOH the patch you sent will lock up hard if the RX FIFO gets stuck for
some other reason which is always a bit concerning...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)