linux-kernel - Re: [PATCH v3 19/19] ACPI: platform_profile: Add a prefix to log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <gwwl4a7o4drpejm7czcciradzv5jyp7hmpwev5jswqlkkb65rq@vbmamxucdmom>
Date: Wed, 15 Jan 2025 15:01:55 -0500
From: Kurt Borja <kuurtb@...il.com>
To: Mario Limonciello <mario.limonciello@....com>
Cc: platform-driver-x86@...r.kernel.org, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Armin Wolf <W_Armin@....de>, 
	Joshua Grisham <josh@...huagrisham.com>, "Derek J. Clark" <derekjohn.clark@...il.com>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, Hans de Goede <hdegoede@...hat.com>, 
	Maximilian Luz <luzmaximilian@...il.com>, "Lee, Chun-Yi" <jlee@...e.com>, 
	Shyam Sundar S K <Shyam-sundar.S-k@....com>, Corentin Chary <corentin.chary@...il.com>, 
	"Luke D. Jones" <luke@...nes.dev>, Lyndon Sanche <lsanche@...deno.ca>, 
	Ike Panhc <ike.pan@...onical.com>, Henrique de Moraes Holschuh <hmh@....eng.br>, 
	Mark Pearson <mpearson-lenovo@...ebb.ca>, Alexis Belmonte <alexbelm48@...il.com>, 
	Ai Chao <aichao@...inos.cn>, Gergo Koteles <soyer@....hu>, Dell.Client.Kernel@...l.com, 
	ibm-acpi-devel@...ts.sourceforge.net
Subject: Re: [PATCH v3 19/19] ACPI: platform_profile: Add a prefix to log
 messages

On Wed, Jan 15, 2025 at 10:45:48AM -0600, Mario Limonciello wrote:
> On 1/15/2025 01:10, Kurt Borja wrote:
> > Declare a pr_fmt prefix.
> > 
> > Signed-off-by: Kurt Borja <kuurtb@...il.com>
> 
> I had to do a bit of a double take because you removed the prefix in patch
> 15/19 of one of existing messages.  So this makes sense at this place in the
> series, thanks!

Yes, I dropped the sanity check error message in favor of WARN_ON_ONCE
because not passing that sanity check would just be a bug. Apart from
that, there was only one more log message that needed the prefix and it
didn't need to be modified.

> 
> Reviewed-by: Mario Limonciello <mario.limonciello@....com>

Thanks!

~ Kurt

> 
> > ---
> >   drivers/acpi/platform_profile.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> > index 4895f37dd549..c9e46b6e27da 100644
> > --- a/drivers/acpi/platform_profile.c
> > +++ b/drivers/acpi/platform_profile.c
> > @@ -2,6 +2,8 @@
> >   /* Platform profile sysfs interface */
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > +
> >   #include <linux/acpi.h>
> >   #include <linux/bits.h>
> >   #include <linux/cleanup.h>
>