linux-kernel - Re: [PATCH v5 03/10] dt-bindings: gpio: ast2400-gpio: Add hogs parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d823325a-1549-44e5-a1b5-6fe0d547cfd1@kernel.org>
Date: Wed, 15 Jan 2025 21:30:26 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Ninad Palsule <ninad@...ux.ibm.com>, minyard@....org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 openipmi-developer@...ts.sourceforge.net, netdev@...r.kernel.org,
 joel@....id.au, andrew@...econstruct.com.au, devicetree@...r.kernel.org,
 eajames@...ux.ibm.com, linux-arm-kernel@...ts.infradead.org,
 linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 03/10] dt-bindings: gpio: ast2400-gpio: Add hogs
 parsing

On 15/01/2025 15:24, Rob Herring wrote:
>>>  
>>> +patternProperties:
>>> +  "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
>>
>> Choose one - suffix or prefix. More popular is suffix.
> 
> I was about to say that, but this matches what gpio-hog.yaml defines. 
> Why we did both, I don't remember. We could probably eliminate 
> 'hog-[0-9]+' as that doesn't appear to be used much.

Only one case:
arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi:                 hog-0 {

Although there are few "hog" prefixes followed by alphanumeric, so not
matching above pattern.

> 
> Long term, I want to make all gpio controllers reference a gpio 
> controller schema and put the hog stuff there. Then we have the node 
> names defined in 1 place.



Best regards,
Krzysztof