linux-kernel - Re: Crash when attaching uretprobes to processes running in Docker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHsH6Gtd5kYPife3hK+uKafjBMx=-23UzvQgnOnqNDzSZgHyqw@mail.gmail.com>
Date: Wed, 15 Jan 2025 13:14:22 -0800
From: Eyal Birger <eyal.birger@...il.com>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, Jiri Olsa <olsajiri@...il.com>, 
	Aleksa Sarai <cyphar@...har.com>, Masami Hiramatsu <mhiramat@...nel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-trace-kernel <linux-trace-kernel@...r.kernel.org>, BPF-dev-list <bpf@...r.kernel.org>, 
	Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, 
	John Fastabend <john.fastabend@...il.com>, Peter Zijlstra <peterz@...radead.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>, X86 ML <x86@...nel.org>, 
	Linux API <linux-api@...r.kernel.org>, Andrii Nakryiko <andrii@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Alexei Starovoitov <ast@...nel.org>, 
	Andrii Nakryiko <andrii.nakryiko@...il.com>, "rostedt@...dmis.org" <rostedt@...dmis.org>, rafi@....io, 
	Shmulik Ladkani <shmulik.ladkani@...il.com>
Subject: Re: Crash when attaching uretprobes to processes running in Docker

On Wed, Jan 15, 2025 at 11:03 AM Oleg Nesterov <oleg@...hat.com> wrote:
>
> On 01/15, Eyal Birger wrote:
> >
> > --- a/kernel/seccomp.c
> > +++ b/kernel/seccomp.c
> > @@ -1359,6 +1359,9 @@ int __secure_computing(const struct seccomp_data *sd)
> >         this_syscall = sd ? sd->nr :
> >                 syscall_get_nr(current, current_pt_regs());
> >
> > +       if (this_syscall == __NR_uretprobe)
> > +               return 0;
> > +
>
> Yes, this is what I meant. But we need the new arch-dependent helper.

Do you mean because __NR_uretprobe is not defined for other architectures?
Is there an existing helper? I wasn't able to find one...

If not, would it just make sense to just wrap this check in
#ifdef __NR_uretprobe ?

Eyal.

>
> Oleg.
>