linux-kernel - Re: [PATCH] can: ctucanfd: handle skb allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <319da2a9-b9a7-43bf-8cb4-bd87b2ebef92@wanadoo.fr>
Date: Wed, 15 Jan 2025 09:40:00 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Fedor Pchelkin <pchelkin@...ras.ru>, Pavel Pisa <pisa@....felk.cvut.cz>,
 Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Ondrej Ille <ondrej.ille@...il.com>,
 Martin Jerabek <martin.jerabek01@...il.com>, linux-can@...r.kernel.org,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] can: ctucanfd: handle skb allocation failure

On 15/01/2025 at 00:21, Fedor Pchelkin wrote:
> If skb allocation fails, the pointer to struct can_frame is NULL. This
> is actually handled everywhere inside ctucan_err_interrupt() except for
> the only place.
> 
> Add the missed NULL check.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE static
> analysis tool.
> 
> Fixes: 2dcb8e8782d8 ("can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.")
> Cc: stable@...r.kernel.org
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>

Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>

Yours sincerely,
Vincent Mailhol