linux-kernel - RE: [PATCH v7 07/15] scsi: fnic: Add and integrate support for FDMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ0PR11MB5896722C05C2573D26DB26B4C3192@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Wed, 15 Jan 2025 01:03:27 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: John Meneghini <jmeneghi@...hat.com>, Dan Carpenter
	<dan.carpenter@...aro.org>
CC: "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>, "Arulprabhu Ponnusamy
 (arulponn)" <arulponn@...co.com>, "Dhanraj Jhawar (djhawar)"
	<djhawar@...co.com>, "Gian Carlo Boffa (gcboffa)" <gcboffa@...co.com>, "Masa
 Kai (mkai2)" <mkai2@...co.com>, "Satish Kharat (satishkh)"
	<satishkh@...co.com>, "Arun Easi (aeasi)" <aeasi@...co.com>,
	"jejb@...ux.ibm.com" <jejb@...ux.ibm.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>
Subject: RE: [PATCH v7 07/15] scsi: fnic: Add and integrate support for FDMI

On Tuesday, January 14, 2025 7:15 AM, John Meneghini <jmeneghi@...hat.com> wrote:
>
> Hi Dan.
>
> I absolutely agree with all of your comments and I appreciate your review.
> I agree that all of the issues you've pointed out, with the the exception of
> one, need to be addressed. The issues pointed out - especially the string
> manipulation issues - can turn into CVEs. We don't want to be checking bugs
> like this into Linux. Certainly, nothing should be merged that does not
> pass the static checker, et al, automated tools we have.
>
> My comment here was only to say that I don't think it's reasonable to
> ask Karan to break this change into a series of 100 small, reviewable changes.
>
> To explain: the fnic driver is Cisco's driver. Cisco has always taken responsibility
> for this driver and Karan is one of the many Cisco Maintainers. What's happening is,
> after a long period of time where the code has been somewhat neglected, Cisco has
> decided to do a major update of their upstream driver. These changes
> are really more like a new driver, with some major new features, than a
> series of bug fixes or updates. This is happening because - at the insistence
> of some of the Distros, like Red Hat - Cisco is being told they need to bring
> their upstream drivers in line with their out-of-box drivers.
>
> Karan can confirm if this is the case. My question for Karan is: are there any more
> major driver changes coming for fnic, or is this the majority of it?
>

This current set of changes is the biggest set.
We have a few more small features planned for the future, not for 6.14.
They are quite limited in their scope.

Regards,
Karan