linux-kernel - Re: [PATCH v1 1/2] landlock: Handle weird files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4dgnkCOc_LxMqq2@infradead.org>
Date: Tue, 14 Jan 2025 23:15:42 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Mickaël Salaün <mic@...ikod.net>
Cc: Günther Noack <gnoack3000@...il.com>,
	Günther Noack <gnoack@...gle.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Paul Moore <paul@...l-moore.com>,
	Dave Chinner <david@...morbit.com>,
	Kent Overstreet <kent.overstreet@...ux.dev>,
	syzbot+34b68f850391452207df@...kaller.appspotmail.com,
	syzbot+360866a59e3c80510a62@...kaller.appspotmail.com,
	Ubisectech Sirius <bugreport@...sectech.com>,
	Brian Foster <bfoster@...hat.com>, linux-bcachefs@...r.kernel.org,
	linux-xfs@...r.kernel.org
Subject: Re: [PATCH v1 1/2] landlock: Handle weird files

On Sat, Jan 11, 2025 at 04:38:56PM +0100, Mickaël Salaün wrote:
> I guess it depends on the filesystem implementation.  For instance, XFS
> returns an error if a weird file is detected [1], whereas bcachefs
> ignores it (which is considered a bug, but not fixed yet) [2].

If a filesyste, returns an invalid mode that's a file system bug and
needs to be fixed there.  Warning in a consumer is perfectly fine.
But the right action in that case is indeed not to grant the access.