linux-kernel - Re: [PATCH next] md/md-linear: Fix a NULL vs IS_ERR() bug in linear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41e896f6-c71b-48c3-8944-eba3dba235cc@huaweicloud.com>
Date: Wed, 15 Jan 2025 15:31:52 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Song Liu <song@...nel.org>, Coly Li <colyli@...nel.org>,
 Mike Snitzer <snitzer@...nel.org>, linux-raid@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH next] md/md-linear: Fix a NULL vs IS_ERR() bug in
 linear_add()

在 2025/01/15 14:53, Dan Carpenter 写道:
> The linear_conf() returns error pointers, it doesn't return NULL.  Update
> the error checking to match.
> 
> Fixes: 127186cfb184 ("md: reintroduce md-linear")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/md/md-linear.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
LGTM
Reviewed-by: Yu Kuai <yukuai3@...wei.com>

> diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
> index 53bc3fda9edb..a382929ce7ba 100644
> --- a/drivers/md/md-linear.c
> +++ b/drivers/md/md-linear.c
> @@ -204,8 +204,8 @@ static int linear_add(struct mddev *mddev, struct md_rdev *rdev)
>   	rdev->saved_raid_disk = -1;
>   
>   	newconf = linear_conf(mddev, mddev->raid_disks + 1);
> -	if (!newconf)
> -		return -ENOMEM;
> +	if (IS_ERR(newconf))
> +		return PTR_ERR(newconf);
>   
>   	/* newconf->raid_disks already keeps a copy of * the increased
>   	 * value of mddev->raid_disks, WARN_ONCE() is just used to make
>