linux-kernel - Re: [PATCH v4 1/4] dt-bindings: clock: spacemit: Add clock controllers of Spacemit K1 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4djvOcKuFhYbfKv@ketchup>
Date: Wed, 15 Jan 2025 07:29:00 +0000
From: Haylen Chu <heylenay@....org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Haylen Chu <heylenay@...look.com>, Yixun Lan <dlan@...too.org>,
	linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Inochi Amaoto <inochiama@...look.com>,
	Chen Wang <unicornxdotw@...mail.com>,
	Jisheng Zhang <jszhang@...nel.org>,
	Meng Zhang <zhangmeng.kevin@...ux.spacemit.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: clock: spacemit: Add clock
 controllers of Spacemit K1 SoC

On Sat, Jan 04, 2025 at 10:58:54AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Jan 03, 2025 at 09:56:34PM +0000, Haylen Chu wrote:
> > +#define CLK_PLL3_80		32
> > +#define CLK_PLL3_40		33
> > +#define CLK_PLL3_20		34
> > +#define CLK_APBS_NUM		35
> 
> Binding looks fine, thanks for the changes, but now I noticed this
> define.  Please drop. Number of clocks is rarely useful as a binding and
> usually leading to ABI issues.
> 
> Same for all other clock controllers below.

Okay, will drop it.

> 
> Best regards,
> Krzysztof
> 

Thanks,
Haylen Chu