linux-kernel - Re: [PATCH] ALSA: usb-audio: Add delay quirk for USB Audio Device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qrcld30.wl-tiwai@suse.de>
Date: Wed, 15 Jan 2025 09:02:11 +0100
From: Takashi Iwai <tiwai@...e.de>
To: 胡连勤 <hulianqin@...o.com>
Cc: "perex@...ex.cz" <perex@...ex.cz>,
	"tiwai@...e.com" <tiwai@...e.com>,
	"lina@...hilina.net" <lina@...hilina.net>,
	"mbarriolinares@...il.com"
	<mbarriolinares@...il.com>,
	"wangdicheng@...inos.cn"
	<wangdicheng@...inos.cn>,
	"cyan.vtb@...il.com" <cyan.vtb@...il.com>,
	"dan.carpenter@...aro.org" <dan.carpenter@...aro.org>,
	"bsevens@...gle.com"
	<bsevens@...gle.com>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Add delay quirk for USB Audio Device

On Wed, 15 Jan 2025 07:45:33 +0100,
胡连勤 wrote:
> 
> From: Lianqin Hu <hulianqin@...o.com>
> 
> Audio control requests that sets sampling frequency sometimes fail on
> this card. Adding delay between control messages eliminates that problem.
> 
> Signed-off-by: Lianqin Hu <hulianqin@...o.com>

Could you give a bit more specific name / model to both the subject
and the quirk comment?  Then it'd be more helpful for people who read
/ check the changes later.


thanks,

Takashi


> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 8ba0aff8be2e..7968d6a2f592 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2239,6 +2239,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
>  	DEVICE_FLG(0x0c45, 0x6340, /* Sonix HD USB Camera */
>  		   QUIRK_FLAG_GET_SAMPLE_RATE),
> +	DEVICE_FLG(0x0d8c, 0x0014, /* USB Audio Device */
> +		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
>  	DEVICE_FLG(0x0ecb, 0x205c, /* JBL Quantum610 Wireless */
>  		   QUIRK_FLAG_FIXED_RATE),
>  	DEVICE_FLG(0x0ecb, 0x2069, /* JBL Quantum810 Wireless */
> -- 
> 2.39.0
>