linux-kernel - Re: [PATCH v2 1/1] phy: rockchip: naneng-combphy: compatible reset with old DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c221084-eef5-434c-9919-f6746eae8e0e@kwiboo.se>
Date: Wed, 15 Jan 2025 09:07:45 +0100
From: Jonas Karlman <jonas@...boo.se>
To: Chukun Pan <amadeus@....edu.cn>
Cc: "heiko@...ech.de" <heiko@...ech.de>, "kishon@...nel.org"
 <kishon@...nel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
 "linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>,
 "liujianfeng1994@...il.com" <liujianfeng1994@...il.com>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 "vkoul@...nel.org" <vkoul@...nel.org>
Subject: Re: [PATCH v2 1/1] phy: rockchip: naneng-combphy: compatible reset
 with old DT

Hi Chukun,

On 2025-01-15 05:00, Chukun Pan wrote:
> Hi,
>> The commit fbcbffbac994 ("phy: rockchip: naneng-combphy: fix phy reset")
>> broke backwards compatibly with old DTs and has already been backported
>> breaking i.e. PCIe and USB on Rockchip RK356x boards on stable and
>> longterm kernels.
> 
> The dts changes have been merged into v6.13-rc7,
> maybe it can be sent to linux-stable.

The original commit broke ABI and does not allow upgrading Linux using
an existing device tree, even if the DT patch adding reset-names props
also is backported you still have uses in the wild e.g. U-Boot v2024.10
and newer that comes bundled with an unpatched DT.

Trying to boot into Linux v6.1.123+, v6.6.69+ and v6.12.8+ using the 
U-Boot bundled DT for RK356x boards now result in broken PCIe, SATA and
USB thanks to the offending commit fbcbffbac994 ("phy: rockchip:
naneng-combphy: fix phy reset").

Regards,
Jonas

> 
> Thanks,
> Chukun
>