linux-kernel - Re: [PATCH v5 2/4] soc: samsung: usi: add a routine for unconfiguring the ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5c471e9-56c2-4674-af3e-1d19b2241bc2@kernel.org>
Date: Wed, 15 Jan 2025 09:25:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Sam Protsenko <semen.protsenko@...aro.org>,
 Peter Griffin <peter.griffin@...aro.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/4] soc: samsung: usi: add a routine for unconfiguring
 the ip

On 14/01/2025 22:59, Ivaylo Ivanov wrote:
> On 1/14/25 19:59, Krzysztof Kozlowski wrote:
>> On 09/01/2025 10:03, Ivaylo Ivanov wrote:
>>>  static int exynos_usi_parse_dt(struct device_node *np, struct exynos_usi *usi)
>>>  {
>>>  	int ret;
>>> @@ -251,6 +268,10 @@ static int exynos_usi_probe(struct platform_device *pdev)
>>>  			return PTR_ERR(usi->regs);
>>>  	}
>>>  
>>> +	ret = devm_add_action_or_reset(&pdev->dev, exynos_usi_unconfigure, usi);
>>> +	if (ret)
>>> +		return ret;
>> You should not reverse the action before the action actually takes place.
>>
>>> +
>>>  	ret = exynos_usi_configure(usi);
>>>  	if (ret)
>>>  		return ret;
>> Registering cleanup should therefore happen here.
> 
> Alright, will fix. I'll try to submit the next (and hopefully final, if that's
> all the critique you have) version in the following days, but I'm currently
> focused on working on exynos2200.

Yeah, rest looks good. Anyway it is too late for this cycle, so I will
pick this (and everything else not picked up) after the merge window.

Best regards,
Krzysztof