linux-kernel - Re: [PATCH v9 0/2] PCI: add enabe(disable)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86bjw8wj05.wl-maz@kernel.org>
Date: Wed, 15 Jan 2025 08:58:50 +0000
From: Marc Zyngier <maz@...nel.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Frank Li <Frank.Li@....com>,	Bjorn Helgaas <bhelgaas@...gle.com>,
	Richard Zhu <hongxing.zhu@....com>,	Lucas Stach <l.stach@...gutronix.de>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,	Krzysztof Wilczyński <kw@...ux.com>,	Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>,	Rob Herring <robh@...nel.org>,	Shawn
 Guo <shawnguo@...nel.org>,	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,	Fabio Estevam
 <festevam@...il.com>,	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,	linux-arm-kernel@...ts.infradead.org,
	imx@...ts.linux.dev,	alyssa@...enzweig.io,	bpf@...r.kernel.org,
	broonie@...nel.org,	jgg@...pe.ca,	joro@...tes.org,	lgirdwood@...il.com,
	p.zabel@...gutronix.de,	robin.murphy@....com,	will@...nel.org
Subject: Re: [PATCH v9 0/2] PCI: add enabe(disable)_device() hook for bridge

On Tue, 14 Jan 2025 22:33:41 +0000,
Bjorn Helgaas <helgaas@...nel.org> wrote:
> 
> On Tue, Jan 14, 2025 at 03:37:07PM -0500, Frank Li wrote:
> > Some system's IOMMU stream(master) ID bits(such as 6bits) less than
> > pci_device_id (16bit). It needs add hardware configuration to enable
> > pci_device_id to stream ID convert.
> > 
> > https://lore.kernel.org/imx/20240622173849.GA1432357@bhelgaas/
> > This ways use pcie bus notifier (like apple pci controller), when new PCIe
> > device added, bus notifier will call register specific callback to handle
> > look up table (LUT) configuration.
> > 
> > https://lore.kernel.org/imx/20240429150842.GC1709920-robh@kernel.org/
> > which parse dt's 'msi-map' and 'iommu-map' property to static config LUT
> > table (qcom use this way). This way is rejected by DT maintainer Rob.
> > 
> > Above ways can resolve LUT take or stream id out of usage the problem. If
> > there are not enough stream id resource, not error return, EP hardware
> > still issue DMA to do transfer, which may transfer to wrong possition.
> > 
> > Add enable(disable)_device() hook for bridge can return error when not
> > enough resource, and PCI device can't enabled.
> > 
> > Basicallly this version can match Bjorn's requirement:
> > 1: simple, because it is rare that there are no LUT resource.
> > 2: EP driver probe failure when no LUT, but lspci can see such device.
> > 
> > [    2.164415] nvme nvme0: pci function 0000:01:00.0
> > [    2.169142] pci 0000:00:00.0: Error enabling bridge (-1), continuing
> > [    2.175654] nvme 0000:01:00.0: probe with driver nvme failed with error -12
> > 
> > > lspci
> > 0000:00:00.0 PCI bridge: Philips Semiconductors Device 0000
> > 0000:01:00.0 Non-Volatile memory controller: Micron Technology Inc 2100AI NVMe SSD [Nitro] (rev 03)
> > 
> > To: Bjorn Helgaas <bhelgaas@...gle.com>
> > To: Richard Zhu <hongxing.zhu@....com>
> > To: Lucas Stach <l.stach@...gutronix.de>
> > To: Lorenzo Pieralisi <lpieralisi@...nel.org>
> > To: Krzysztof Wilczyński <kw@...ux.com>
> > To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > To: Rob Herring <robh@...nel.org>
> > To: Shawn Guo <shawnguo@...nel.org>
> > To: Sascha Hauer <s.hauer@...gutronix.de>
> > To: Pengutronix Kernel Team <kernel@...gutronix.de>
> > To: Fabio Estevam <festevam@...il.com>
> > Cc: linux-pci@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Cc: linux-arm-kernel@...ts.infradead.org
> > Cc: imx@...ts.linux.dev
> > Cc: Frank.li@....com \
> > Cc: alyssa@...enzweig.io \
> > Cc: bpf@...r.kernel.org \
> > Cc: broonie@...nel.org \
> > Cc: jgg@...pe.ca \
> > Cc: joro@...tes.org \
> > Cc: l.stach@...gutronix.de \
> > Cc: lgirdwood@...il.com \
> > Cc: maz@...nel.org \
> > Cc: p.zabel@...gutronix.de \
> > Cc: robin.murphy@....com \
> > Cc: will@...nel.org \
> > Cc: Robin Murphy <robin.murphy@....com>
> > Cc: Marc Zyngier <maz@...nel.org>
> > 
> > Signed-off-by: Frank Li <Frank.Li@....com>
> 
> Applied to pci/controller/imx6 for v6.14, thanks!  And thanks for your
> patience.

While you're at it, could you please consider [1], which builds on top
of the same infrastructure to remove the Apple PCIe IOMMU hack?

Thanks,

	M.

[1] https://lore.kernel.org/linux-pci/20241204150145.800408-1-maz@kernel.org/

-- 
Without deviation from the norm, progress is not possible.