linux-kernel - Re: [PATCH v3 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA233 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5rqo6fryvx76sta3cvjm55i7khiezj7dlspyij3jwzefsrtqq@rf7fzrt4yyo6>
Date: Wed, 15 Jan 2025 10:42:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Leo Yang <leo.yang.sy0@...il.com>
Cc: jdelvare@...e.com, linux@...ck-us.net, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, Leo-Yang@...ntatw.com, corbet@....net, 
	Delphine_CC_Chiu@...ynn.com, linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA233 device

On Wed, Jan 15, 2025 at 09:55:20AM +0800, Leo Yang wrote:
> @@ -75,12 +76,40 @@ properties:
>        the alert polarity to active-high.
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  ti,current-lsb-microamp:
> +    description: |
> +      This value depends on the maximum current that can be expected to be
> +      measured by ina233 in your circuit, divide Maximum Expected Current
> +      by 2^15 and express it in microamps.

No, express here maximum expected current. Otherwise what is here?
Define the physical property, not the value used by your driver.

> +
> +      This value will be used to calculate the current/power coefficient for
> +      the pmbus and to calibrate the IC.
> +    minimum: 0x1

s/0x1/1/

maximum?
default?

> +
>  required:
>    - compatible
>    - reg

Best regards,
Krzysztof