linux-kernel - Re: [Linux-stm32] [PATCH] pinctrl: Use str_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e60d2c600133df2202bf3187eeeb9c31bc6c8f32.camel@foss.st.com>
Date: Wed, 15 Jan 2025 10:39:33 +0100
From: Antonio Borneo <antonio.borneo@...s.st.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Ray Jui
	<rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
        "Broadcom
 internal kernel review list" <bcm-kernel-feedback-list@...adcom.com>,
        "Linus
 Walleij" <linus.walleij@...aro.org>,
        Charles Keepax
	<ckeepax@...nsource.cirrus.com>,
        Richard Fitzgerald
	<rf@...nsource.cirrus.com>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Hans Ulli Kroll
	<ulli.kroll@...glemail.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        "Sylwester
 Nawrocki" <s.nawrocki@...sung.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <patches@...nsource.cirrus.com>,
        <linux-sound@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>
Subject: Re: [Linux-stm32] [PATCH] pinctrl: Use str_enable_disable-like
 helpers

On Tue, 2025-01-14 at 21:36 +0100, Krzysztof Kozlowski wrote:
> Replace ternary (condition ? "enable" : "disable") syntax with helpers
> from string_choices.h because:
> 1. Simple function call with one argument is easier to read.  Ternary
>    operator has three arguments and with wrapping might lead to quite
>    long code.
> 2. Is slightly shorter thus also easier to read.
> 3. It brings uniformity in the text - same string.
> 4. Allows deduping by the linker, which results in a smaller binary
>    file.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/pinctrl/bcm/pinctrl-nsp-gpio.c     |  3 ++-
>  drivers/pinctrl/cirrus/pinctrl-lochnagar.c |  3 ++-
>  drivers/pinctrl/nomadik/pinctrl-abx500.c   |  5 +++--
>  drivers/pinctrl/nomadik/pinctrl-nomadik.c  |  7 ++++---
>  drivers/pinctrl/pinctrl-amd.c              |  3 ++-
>  drivers/pinctrl/pinctrl-gemini.c           | 11 ++++++-----
>  drivers/pinctrl/pinctrl-stmfx.c            |  2 +-
>  drivers/pinctrl/qcom/pinctrl-msm.c         |  3 ++-
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c   |  3 ++-
>  drivers/pinctrl/qcom/pinctrl-spmi-mpp.c    |  3 ++-
>  drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c   |  3 ++-
>  drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c    | 10 ++++------
>  drivers/pinctrl/samsung/pinctrl-exynos.c   |  3 ++-
>  drivers/pinctrl/stm32/pinctrl-stm32.c      |  5 +++--

For pinctrl-stmfx and for pinctrl-stm32:

Reviewed-by: Antonio Borneo <antonio.borneo@...s.st.com>
---
Antonio