linux-kernel - Re: [PATCH] kasan: hw_tags: Use str_on_off() helper in kasan_init_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+fCnZcqRnHyMfHwXFSFY_4wmhLg5jOsTsbV5oLKx=suBfNXEg@mail.gmail.com>
Date: Wed, 15 Jan 2025 02:45:08 +0100
From: Andrey Konovalov <andreyknvl@...il.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Andrey Ryabinin <ryabinin.a.a@...il.com>, Alexander Potapenko <glider@...gle.com>, 
	Dmitry Vyukov <dvyukov@...gle.com>, Vincenzo Frascino <vincenzo.frascino@....com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Anshuman Khandual <anshuman.khandual@....com>, 
	kasan-dev@...glegroups.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kasan: hw_tags: Use str_on_off() helper in kasan_init_hw_tags()

On Tue, Jan 14, 2025 at 4:10 PM Thorsten Blum <thorsten.blum@...ux.dev> wrote:
>
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Suggested-by: Anshuman Khandual <anshuman.khandual@....com>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  mm/kasan/hw_tags.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c
> index ccd66c7a4081..9a6927394b54 100644
> --- a/mm/kasan/hw_tags.c
> +++ b/mm/kasan/hw_tags.c
> @@ -16,6 +16,7 @@
>  #include <linux/mm.h>
>  #include <linux/static_key.h>
>  #include <linux/string.h>
> +#include <linux/string_choices.h>
>  #include <linux/types.h>
>  #include <linux/vmalloc.h>
>
> @@ -263,8 +264,8 @@ void __init kasan_init_hw_tags(void)
>
>         pr_info("KernelAddressSanitizer initialized (hw-tags, mode=%s, vmalloc=%s, stacktrace=%s)\n",
>                 kasan_mode_info(),
> -               kasan_vmalloc_enabled() ? "on" : "off",
> -               kasan_stack_collection_enabled() ? "on" : "off");
> +               str_on_off(kasan_vmalloc_enabled()),
> +               str_on_off(kasan_stack_collection_enabled()));
>  }
>
>  #ifdef CONFIG_KASAN_VMALLOC
> --
> 2.47.1
>

Reviewed-by: Andrey Konovalov <andreyknvl@...il.com>

Thanks!