linux-kernel - Re: [PATCH] wifi: ath11k: allow APs combination when dual stations are supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1090a0e4-6a19-422f-83ad-4566e5c86015@quicinc.com>
Date: Wed, 15 Jan 2025 18:48:40 +0800
From: "Yu Zhang (Yuriy)" <quic_yuzha@...cinc.com>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
CC: <ath11k@...ts.infradead.org>, <jjohnson@...nel.org>, <kvalo@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
        <quic_cjhuang@...cinc.com>, <vbenes@...hat.com>
Subject: Re: [PATCH] wifi: ath11k: allow APs combination when dual stations
 are supported



On 1/15/2025 5:46 PM, Jose Ignacio Tornos Martinez wrote:
> Hello Yuriy,
> 
> We can debug/configure NetworkManager on our own to get what we need.
> Now, I am just trying to get a solution because at this moment 2APs can not
> be configured as before.
> As I commented, if you want to have a common interface combination, please
> go ahead with yours, and then we can see.
> 
> Thanks
> 
> Best regards
> Jose Ignacio
> 
Hi, Jose

When you use 
https://lore.kernel.org/all/20230714023801.2621802-2-quic_cjhuang@quicinc.com/, 
the ap only allow 1, it's expected.

+	if (ab->hw_params.support_dual_stations) {
+		limits[0].max = 2;
+		limits[0].types |= BIT(NL80211_IFTYPE_STATION);
+
+		limits[1].max = 1;
+		limits[1].types |= BIT(NL80211_IFTYPE_AP);


In 
https://lore.kernel.org/all/20241125100508.3458594-1-quic_yuzha@quicinc.com/, 
revert the limits[1].max, it's why can work for my device. When you use 
combinations[0], it's all same as before. So ath11k can support 
STA+SAP+SAP mode(not include DFS).

Now I wonder to know why it doesn't work on your device, which is why I 
asked you to provide the logs.


Thanks,
Yuriy