linux-kernel - Re: [PATCH v5] PCI: rcar-ep: Fix the issue of the name parameter when calling devm_request_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250115112117.GF4176564@rocinante>
Date: Wed, 15 Jan 2025 20:21:17 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: kingdix10@...com
Cc: marek.vasut+renesas@...il.com, yoshihiro.shimoda.uh@...esas.com,
	lpieralisi@...nel.org, manivannan.sadhasivam@...aro.org,
	robh@...nel.org, bhelgaas@...gle.com, prabhakar.csengg@...il.com,
	biju.das.jz@...renesas.com, geert@...ux-m68k.org,
	prabhakar.mahadev-lad.rj@...renesas.com, linux-pci@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] PCI: rcar-ep: Fix the issue of the name parameter
 when calling devm_request_mem_region()

Hello,

> When using devm_request_mem_region() to request a resource and the name
> parameter is a stack string variable, it may cause errors when executing
> the command `cat /proc/iomem`. Depending on the content of the memory, the
> manifestations of errors may vary. One possible output may be as follows:
> 
> $ cat /proc/iomem
> 30000000-37ffffff :
> 38000000-3fffffff :
> 
> Another possibility is that garbage characters may appear after the colon.
> In very rare cases, if no NUL-terminator is found in memory, the system
> might crash because the string iterator may access unmapped memory above
> the stack.
> 
> Fix this by replacing outbound_name with the name of the previously
> requested resource. With the patch applied, the output is as follows:
> 
> $ cat /proc/iomem
> 30000000-37ffffff : memory2
> 38000000-3fffffff : memory3

Applied to controller/rcar-ep for v6.14, thank you!

	Krzysztof