linux-kernel - Re: [PATCH] rust: irq: add support for request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250115113836.18992e92.gary@garyguo.net>
Date: Wed, 15 Jan 2025 11:38:36 +0000
From: Gary Guo <gary@...yguo.net>
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: Alice Ryhl <aliceryhl@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, Alex
 Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
 <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, Trevor
 Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: irq: add support for request_irq()

On Tue, 14 Jan 2025 15:57:57 -0300
Daniel Almeida <daniel.almeida@...labora.com> wrote:

> > 
> > It's not the pin_init! stuff, but the Opaque stuff. If it fails, then
> > it runs the destructor of Opaque<T>, which does *not* run the
> > destructor of T.
> > 
> > Alice  
> 
> This is pretty unintuitive if you take into account trivial examples like
> 
> ```
> struct Foo(T)
> ```
> 
> Where dropping Foo drops T.
> 
> Is there any reason why dropping Opaque<T> doesn’t behave similarly?
> 
> — Daniel

`Opaque` means that "this is a blob of bytes and don't touch it". It
can be uninitialized, so no meaningful action can be performed when
it's dropped.

Best,
Gary