linux-kernel - Re: [PATCH] ufs: Use str_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e03650cf09417680b35bc57c7b8c434733d86d12.camel@mediatek.com>
Date: Wed, 15 Jan 2025 11:50:21 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "avri.altman@....com" <avri.altman@....com>, "chu.stanley@...il.com"
	<chu.stanley@...il.com>, "krzysztof.kozlowski@...aro.org"
	<krzysztof.kozlowski@...aro.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "bvanassche@....org"
	<bvanassche@....org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] ufs: Use str_enable_disable-like helpers

On Tue, 2025-01-14 at 21:07 +0100, Krzysztof Kozlowski wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Replace ternary (condition ? "enable" : "disable") syntax with
> helpers
> from string_choices.h because:
> 1. Simple function call with one argument is easier to read.  Ternary
>    operator has three arguments and with wrapping might lead to quite
>    long code.
> 2. Is slightly shorter thus also easier to read.
> 3. It brings uniformity in the text - same string.
> 4. Allows deduping by the linker, which results in a smaller binary
>    file.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/ufs/core/ufshcd.c       | 11 ++++++-----
>  drivers/ufs/host/ufs-mediatek.c |  7 +++----
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>