linux-kernel - Re: [PATCH] genirq/timings: add kernel-doc for a function param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6ef436f-9f18-408e-9b24-e6464176a0a5@linaro.org>
Date: Wed, 15 Jan 2025 13:09:21 +0100
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Thomas Gleixner <tglx@...utronix.de>, Randy Dunlap
 <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] genirq/timings: add kernel-doc for a function param

Hi Thomas,

[Cc'ed Ulf]

On 15/01/2025 10:59, Thomas Gleixner wrote:
> On Fri, Jan 10 2025 at 22:29, Randy Dunlap wrote:
> 
>> Add the description for @now to eliminate a kernel-doc warning.
>> (Is this function used? I don't see it being called.)
> 
> That's indeed a good question.
> 
> Daniel, what's the state of this after 7+ years of being in "comes soon"
> state?

We recently discussed that with Ulf.

The next irq prediction would greatly help during the DSU [1] shut down 
process. As the last CPU going down initiates the DSU shut down, there 
are no more IPI involved and the timer + irq prediction will be much 
more accurate.

However, it is clear that we are talking about this feature since a long 
time and we did not finish its implementation yet, so it is not really 
serious to ask for more retention in the kernel if it is unused.

On the other side, it took me a lot of effort to elaborate the suffix 
based algorithm for the prediction and it would be a pity if we drop it 
because of the lack of progress :(

So, here is my proposal. Ulf and I will do the changes for the DSU power 
down which is reasonable to say it can happen during the next cycle. If 
there is nothing for the end of the next cycle, then we remove the code.

Does it sound good ?

[1] https://developer.arm.com/Processors/DSU-120

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog