linux-kernel - Re: [PATCH v5] PCI: dwc: Clean up some unnecessary codes in dw_pcie_suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250115131055.GU4176564@rocinante>
Date: Wed, 15 Jan 2025 22:10:55 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Richard Zhu <hongxing.zhu@....com>
Cc: jingoohan1@...il.com, bhelgaas@...gle.com, lpieralisi@...nel.org,
	manivannan.sadhasivam@...aro.org, robh@...nel.org, frank.li@....com,
	quic_krichai@...cinc.com, imx@...ts.linux.dev,
	kernel@...gutronix.de, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] PCI: dwc: Clean up some unnecessary codes in
 dw_pcie_suspend_noirq()

Hello,

> Before sending PME_TURN_OFF, don't test the LTSSM state. Since it's safe
> to send PME_TURN_OFF message regardless of whether the link is up or
> down. So, there would be no need to test the LTSSM state before sending
> PME_TURN_OFF message.
> 
> Only print the message when ltssm_stat is not in DETECT and POLL.
> In the other words, there isn't an error message when no endpoint is
> connected at all.

I applied the same patch from the following series:

  https://lore.kernel.org/linux-pci/20241210081557.163555-1-hongxing.zhu@nxp.com

The above one is still a v4.  Hopefully, there is no issue with using the
other series.  However, if you prefer this version here, then do let me
know, so I can mend things directly on the branch itself.

Thank you!

	Krzysztof