lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d8d3d83f-42d5-47a0-8e96-0b3e70a736ee@sirena.org.uk>
Date: Thu, 16 Jan 2025 15:58:42 +0000
From: Mark Brown <broonie@...nel.org>
To: Jonas Andreasson <jonas.andreasson@...s.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
	kernel@...s.com
Subject: Re: [PATCH] regulator: TPS6287X: Use min/max uV to get VRANGE

On Wed, Jan 15, 2025 at 10:55:22AM +0100, Jonas Andreasson wrote:

> +	if (!data || data->range == -1)
> +		goto fallback;

...

> +	return selector;
> +
> +fallback:
> +	return regulator_map_voltage_pickable_linear_range(rdev, min_uV, max_uV);

You could just have the return statement directly and avoid the goto
which would make this easier to follow.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ