linux-kernel - [PATCH RFC v2 7/8] dm-io: Warn on creating multiple atomic write bios for a region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250116170301.474130-8-john.g.garry@oracle.com>
Date: Thu, 16 Jan 2025 17:03:00 +0000
From: John Garry <john.g.garry@...cle.com>
To: axboe@...nel.dk, agk@...hat.com, mpatocka@...hat.com, hch@....de
Cc: song@...nel.org, yukuai3@...wei.com, kbusch@...nel.org, sagi@...mberg.me,
        James.Bottomley@...senPartnership.com, martin.petersen@...cle.com,
        linux-block@...r.kernel.org, dm-devel@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-scsi@...r.kernel.org,
        John Garry <john.g.garry@...cle.com>
Subject: [PATCH RFC v2 7/8] dm-io: Warn on creating multiple atomic write bios for a region

A region should just be for a single atomic write, so warn when we are
creating many. This should not occur if request queue limits are properly
configured.

Signed-off-by: John Garry <john.g.garry@...cle.com>
---
 drivers/md/dm-io.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
index d7a8e2f40db3..c37668790577 100644
--- a/drivers/md/dm-io.c
+++ b/drivers/md/dm-io.c
@@ -379,6 +379,7 @@ static void do_region(const blk_opf_t opf, unsigned int region,
 
 		atomic_inc(&io->count);
 		submit_bio(bio);
+		WARN_ON_ONCE(opf & REQ_ATOMIC && remaining);
 	} while (remaining);
 }
 
-- 
2.31.1