linux-kernel - Re: [PATCH v2] Documentation/cgroup-v2: Update memory.{stat,numa_stat} description to reflect possible units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4k_kLW_a_D50v1I@slm.duckdns.org>
Date: Thu, 16 Jan 2025 07:19:12 -1000
From: Tejun Heo <tj@...nel.org>
To: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
Cc: Jonathan Corbet <corbet@....net>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Johannes Weiner <hannes@...xchg.org>,
	"mkoutny@...e.com" <mkoutny@...e.com>,
	"cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Waiman Long <llong@...hat.com>
Subject: Re: [PATCH v2] Documentation/cgroup-v2: Update
 memory.{stat,numa_stat} description to reflect possible units

Hello,

On Thu, Jan 16, 2025 at 05:50:54AM +0000, Zhijian Li (Fujitsu) wrote:
...
> Let me quote a piece of the numa.stat:
> 
> In pages:
> >          pgdemote_khugepaged                                                   
> >                Number of pages demoted by khugepaged.

If this is the only entry in pages, I'm not sure the proposed document
update is the best one. The above can have an easy alternative description
"the number of times khugepaged demoted a huge page" - ie. indicate that it
is an event counter instead, which is a plausible and likely more intuitive
definition anyway given that a "huge page" can plausibly be of different
sizes. With the key name and matching description, I'm not sure it's
violating the rule that all *sizes* are expressed in bytes.

Thanks.

-- 
tejun