linux-kernel - [PATCH][next] PCI: Fix ternary operator that never returns 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250116172019.88116-1-colin.i.king@gmail.com>
Date: Thu, 16 Jan 2025 17:20:19 +0000
From: Colin Ian King <colin.i.king@...il.com>
To: Bjorn Helgaas <bhelgaas@...gle.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-pci@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH][next] PCI: Fix ternary operator that never returns 0

The left hand size of the ? operator is always true because of the addition
of PCIE_STD_NUM_TLP_HEADERLOG and so dev->eetlp_prefix_max is always being
returned and the 0 is never returned (dead code). Fix this by adding the
required parentheses around the ternary operator.

Fixes: 00048c2d5f11 ("PCI: Add TLP Prefix reading to pcie_read_tlp_log()")
Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 drivers/pci/pcie/tlp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pcie/tlp.c b/drivers/pci/pcie/tlp.c
index 9b9e348fb1a0..0860b5da837f 100644
--- a/drivers/pci/pcie/tlp.c
+++ b/drivers/pci/pcie/tlp.c
@@ -22,8 +22,8 @@
 unsigned int aer_tlp_log_len(struct pci_dev *dev, u32 aercc)
 {
 	return PCIE_STD_NUM_TLP_HEADERLOG +
-	       (aercc & PCI_ERR_CAP_PREFIX_LOG_PRESENT) ?
-	       dev->eetlp_prefix_max : 0;
+	       ((aercc & PCI_ERR_CAP_PREFIX_LOG_PRESENT) ?
+		dev->eetlp_prefix_max : 0);
 }
 
 #ifdef CONFIG_PCIE_DPC
-- 
2.47.1