linux-kernel - Re: [PATCH] locking/mutex: Mark devm_mutex_init() as __must

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <404d182e-ba2a-480c-bcbd-4497350fc561@t-8ch.de>
Date: Thu, 16 Jan 2025 18:31:32 +0100
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>, 
	Boqun Feng <boqun.feng@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] locking/mutex: Mark devm_mutex_init() as __must_check

On 2025-01-16 17:45:30+0200, Andy Shevchenko wrote:
> On Mon, Dec 02, 2024 at 06:45:41PM +0100, Thomas Weißschuh wrote:
> > Even if it's not critical, the avoidance of checking the error code
> > from devm_mutex_init() call today diminishes the point of using devm
> > variant of it. Tomorrow it may even leak something. Enforce all callers
> > checking the return value through the compiler.
> > 
> > As devm_mutex_init() itself is a macro which can not be annotated,
> > annotate __devm_mutex_init() instead.
> > Unfortunately __must_check/warn_unused_result don't propagate through
> > statement expression. To work around this move the statement expression
> > into the argument list of the call to __devm_mutex_init() so
> > devm_mutex_init() directly expands to __devm_mutex_init().
> 
> Did it go anywhere?

Nope. I'll resend it after -rc1.
Maybe a Reviewed-by also helps.