linux-kernel - Re: [PATCH net-next v04 1/1] hinic3: module initialization and tx/rx logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250116181037.GE6206@kernel.org>
Date: Thu, 16 Jan 2025 18:10:37 +0000
From: Simon Horman <horms@...nel.org>
To: Gur Stavi <gur.stavi@...wei.com>
Cc: gongfan <gongfan1@...wei.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, linux-doc@...r.kernel.org,
	Jonathan Corbet <corbet@....net>,
	Bjorn Helgaas <helgaas@...nel.org>,
	Cai Huoqing <cai.huoqing@...ux.dev>, luosifu <luosifu@...wei.com>,
	Xin Guo <guoxin09@...wei.com>,
	Shen Chenyang <shenchenyang1@...ilicon.com>,
	Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>,
	Shi Jing <shijing34@...wei.com>,
	Meny Yossefi <meny.yossefi@...wei.com>,
	Suman Ghosh <sumang@...vell.com>
Subject: Re: [PATCH net-next v04 1/1] hinic3: module initialization and tx/rx
 logic

On Thu, Jan 16, 2025 at 09:51:53AM +0200, Gur Stavi wrote:
> From: gongfan <gongfan1@...wei.com>
> 
> This is [1/3] part of hinic3 Ethernet driver initial submission.
> With this patch hinic3 is a valid kernel module but non-functional
> driver.
> 
> The driver parts contained in this patch:
> Module initialization.
> PCI driver registration but with empty id_table.
> Auxiliary driver registration.
> Net device_ops registration but open/stop are empty stubs.
> tx/rx logic.
> 
> All major data structures of the driver are fully introduced with the
> code that uses them but without their initialization code that requires
> management interface with the hw.
> 
> Submitted-by: Gur Stavi <gur.stavi@...wei.com>
> Signed-off-by: Gur Stavi <gur.stavi@...wei.com>
> Signed-off-by: Xin Guo <guoxin09@...wei.com>
> Signed-off-by: gongfan <gongfan1@...wei.com>

...

> diff --git a/Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst b/Documentation/networking/device_drivers/ethernet/huawei/hinic3.rst

...

> +Completion Event Queue (CEQ)
> +--------------------------

nit: the length of the "---" line doesn't match that of the line above it.

...