linux-kernel - Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user space tracing tools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250116143018.0b156e42@gandalf.local.home>
Date: Thu, 16 Jan 2025 14:30:18 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>, linux-mm@...ck.org,
 linux-perf-users@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Michael Petlan <mpetlan@...hat.com>, Veronika
 Molnarova <vmolnaro@...hat.com>, Suren Baghdasaryan <surenb@...gle.com>
Subject: Re: [PATCH] tracing: gfp: Fix the GFP enum values shown for user
 space tracing tools

On Thu, 16 Jan 2025 11:19:20 -0800
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Thu, 16 Jan 2025 at 11:17, Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > But they are only defines, they are not created until used. Are you worried
> > that it will slow down the compile?  
> 
> Yes, and the whole "pointless noise" thing.
> 
> I *look* at header files sometimes. I don't want to see pointless
> noise that isn't relevant to the context.
> 
> This is not relevant to non-tracing users.

Would it at least be OK to add a comment there to update the tracing code
if a new GFP flag is added?

/*
 * If a new GFP flag is added, a new TRACE_DEFINE_ENUM needs to be added
 * in path/to/where/define/is/made.h
 */


?

-- Steve