linux-kernel - Re: [PATCH] watchdog: cros-ec: Add newlines to printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7a4c031-cc31-4a9e-8865-f23d5460ddcb@roeck-us.net>
Date: Thu, 16 Jan 2025 14:54:51 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Stephen Boyd <swboyd@...omium.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc: linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
 chrome-platform@...ts.linux.dev, linux-watchdog@...r.kernel.org,
 Lukasz Majczak <lma@...omium.org>, Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH] watchdog: cros-ec: Add newlines to printks

On 1/16/25 14:46, Stephen Boyd wrote:
> Add newlines to printk messages so that the next record is more easily
> readable.
> 
> Cc: Lukasz Majczak <lma@...omium.org>
> Cc: Benson Leung <bleung@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/cros_ec_wdt.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wdt.c
> index ba045e29f9a5..716c23f4388c 100644
> --- a/drivers/watchdog/cros_ec_wdt.c
> +++ b/drivers/watchdog/cros_ec_wdt.c
> @@ -58,7 +58,7 @@ static int cros_ec_wdt_ping(struct watchdog_device *wdd)
>   	arg.req.command = EC_HANG_DETECT_CMD_RELOAD;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to ping watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to ping watchdog (%d)\n", ret);
>   
>   	return ret;
>   }
> @@ -74,7 +74,7 @@ static int cros_ec_wdt_start(struct watchdog_device *wdd)
>   	arg.req.reboot_timeout_sec = wdd->timeout;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to start watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to start watchdog (%d)\n", ret);
>   
>   	return ret;
>   }
> @@ -88,7 +88,7 @@ static int cros_ec_wdt_stop(struct watchdog_device *wdd)
>   	arg.req.command = EC_HANG_DETECT_CMD_CANCEL;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		dev_dbg(wdd->parent, "Failed to stop watchdog (%d)", ret);
> +		dev_dbg(wdd->parent, "Failed to stop watchdog (%d)\n", ret);
>   
>   	return ret;
>   }
> @@ -136,7 +136,7 @@ static int cros_ec_wdt_probe(struct platform_device *pdev)
>   	arg.req.command = EC_HANG_DETECT_CMD_GET_STATUS;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus");
> +		return dev_err_probe(dev, ret, "Failed to get watchdog bootstatus\n");
>   
>   	wdd->parent = &pdev->dev;
>   	wdd->info = &cros_ec_wdt_ident;
> @@ -150,7 +150,7 @@ static int cros_ec_wdt_probe(struct platform_device *pdev)
>   	arg.req.command = EC_HANG_DETECT_CMD_CLEAR_STATUS;
>   	ret = cros_ec_wdt_send_cmd(cros_ec, &arg);
>   	if (ret < 0)
> -		return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus");
> +		return dev_err_probe(dev, ret, "Failed to clear watchdog bootstatus\n");
>   
>   	watchdog_stop_on_reboot(wdd);
>   	watchdog_stop_on_unregister(wdd);
> 
> base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532