linux-kernel - Re: [PATCH v3 17/27] spi: zynqmp-gqspi: Support per spi-mem operation frequency switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a14851c1-9ec1-46ef-8862-97c94a1a633a@seco.com>
Date: Thu, 16 Jan 2025 18:41:52 -0500
From: Sean Anderson <sean.anderson@...o.com>
To: miquel.raynal@...tlin.com, linux-spi@...r.kernel.org
Cc: Michal Simek <michal.simek@....com>, Mark Brown <broonie@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 17/27] spi: zynqmp-gqspi: Support per spi-mem operation
 frequency switches

> Every ->exec_op() call correctly configures the spi bus speed to the
> maximum allowed frequency for the memory using the constant spi default
> parameter. Since we can now have per-operation constraints, let's use
> the value that comes from the spi-mem operation structure instead. In
> case there is no specific limitation for this operation, the default spi
> device value will be given anyway.
> 
> The per-operation frequency capability is thus advertised to the spi-mem
> core.
> 
> Cc: Michal Simek <michal.simek@....com>
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> ---
>  drivers/spi/spi-zynqmp-gqspi.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)

Reviewed-by: Sean Anderson <sean.anderson@...ux.dev>

But this will conflict with [1]. Do you think you could add that to your
series? With that patch, you'd have something like

-	zynqmp_qspi_config_op(xqspi, mem->spi->max_speed_hz);
+	zynqmp_qspi_config_op(xqspi, op->max_freq);

instead. I can send that patch by itself if it would make things easier
for you.

--Sean

[1] https://lore.kernel.org/linux-spi/20250116232118.2694169-3-sean.anderson@linux.dev/