[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250116235339.300485-3-sboyd@kernel.org>
Date: Thu, 16 Jan 2025 15:53:38 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>,
linux-kernel@...r.kernel.org,
patches@...ts.linux.dev
Subject: [PATCH 2/2] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe()
From: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
spmi_controller_probe() assigns a parent device and an OF node to an
SPMI controller. However, the operations are not needed as they are
already assigned in spmi_controller_alloc(). Thus, remove the duplicated
assignments. An unnecessary OF node reference acquisition is also
dropped by this patch.
Signed-off-by: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Suggested-by: Stephen Boyd <sboyd@...nel.org>
Link: https://lore.kernel.org/r/20250116044907.2947218-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Stephen Boyd <sboyd@...nel.org>
---
drivers/spmi/hisi-spmi-controller.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
index 3cafdf22c909..122140b97579 100644
--- a/drivers/spmi/hisi-spmi-controller.c
+++ b/drivers/spmi/hisi-spmi-controller.c
@@ -300,9 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev)
spin_lock_init(&spmi_controller->lock);
- ctrl->dev.parent = pdev->dev.parent;
- ctrl->dev.of_node = of_node_get(pdev->dev.of_node);
-
/* Callbacks */
ctrl->read_cmd = spmi_read_cmd;
ctrl->write_cmd = spmi_write_cmd;
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Powered by blists - more mailing lists