linux-kernel - RE: linux-next: build failure after merge of the wireless-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e19a87ad9cd54bfa9907f3a043b25d30@realtek.com>
Date: Thu, 16 Jan 2025 05:49:28 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Stephen Rothwell <sfr@...b.auug.org.au>, Kalle Valo <kvalo@...nel.org>,
        Johannes Berg <johannes@...solutions.net>
CC: Bitterblue Smith <rtl8821cerfe2@...il.com>,
        Wireless
	<linux-wireless@...r.kernel.org>,
        Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>,
        Linux Next Mailing List
	<linux-next@...r.kernel.org>
Subject: RE: linux-next: build failure after merge of the wireless-next tree

Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> Hi all,
> 
> After merging the wireless-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/net/wireless/realtek/rtw88/led.c:19:6: error: redefinition of 'rtw_led_init'
>    19 | void rtw_led_init(struct rtw_dev *rtwdev)
>       |      ^~~~~~~~~~~~
> In file included from drivers/net/wireless/realtek/rtw88/led.c:7:
> drivers/net/wireless/realtek/rtw88/led.h:15:20: note: previous definition of 'rtw_led_init' with type
> 'void(struct rtw_dev *)'
>    15 | static inline void rtw_led_init(struct rtw_dev *rtwdev)
>       |                    ^~~~~~~~~~~~
> drivers/net/wireless/realtek/rtw88/led.c:64:6: error: redefinition of 'rtw_led_deinit'
>    64 | void rtw_led_deinit(struct rtw_dev *rtwdev)
>       |      ^~~~~~~~~~~~~~
> drivers/net/wireless/realtek/rtw88/led.h:19:20: note: previous definition of 'rtw_led_deinit' with type
> 'void(struct rtw_dev *)'
>    19 | static inline void rtw_led_deinit(struct rtw_dev *rtwdev)
>       |                    ^~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   4b6652bc6d8d ("wifi: rtw88: Add support for LED blinking")
> 
> I have used the wireless-next tree from next-20250115 for today.

I reproduced this issue, and fixed it by a patch [1].

[1] https://lore.kernel.org/linux-wireless/20250116054337.35723-1-pkshih@realtek.com/T/#u