Message-ID: <20250116-light-panda-of-reverence-2f5da8-mkl@pengutronix.de>
Date: Thu, 16 Jan 2025 08:53:42 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Kees Cook <kees@...nel.org>
Cc: Jakub Kicinski <kuba@...nel.org>, 
	Cheng Xu <chengyou@...ux.alibaba.com>, Kai Shen <kaishen@...ux.alibaba.com>, 
	Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, 
	Christian Benvenuti <benve@...co.com>, Nelson Escobar <neescoba@...co.com>, 
	Bernard Metzler <bmt@...ich.ibm.com>, Karsten Keil <isdn@...ux-pingi.de>, 
	Michal Ostrowski <mostrows@...thlink.net>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>, 
	Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, 
	Chaitanya Kulkarni <kch@...dia.com>, Lee Duncan <lduncan@...e.com>, Chris Leech <cleech@...hat.com>, 
	Mike Christie <michael.christie@...cle.com>, "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K. Petersen" <martin.petersen@...cle.com>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Alexander Aring <aahringo@...hat.com>, 
	David Teigland <teigland@...hat.com>, Trond Myklebust <trondmy@...nel.org>, 
	Anna Schumaker <anna@...nel.org>, Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>, 
	Joseph Qi <joseph.qi@...ux.alibaba.com>, Namjae Jeon <linkinjeon@...nel.org>, 
	Steve French <sfrench@...ba.org>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Tom Talpey <tom@...pey.com>, Simon Horman <horms@...nel.org>, 
	Chuck Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>, 
	Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, David Ahern <dsahern@...nel.org>, 
	Joerg Reuter <jreuter@...na.de>, Marcel Holtmann <marcel@...tmann.org>, 
	Johan Hedberg <johan.hedberg@...il.com>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
	Oliver Hartkopp <socketcan@...tkopp.net>, Robin van der Gracht <robin@...tonic.nl>, 
	Oleksij Rempel <o.rempel@...gutronix.de>, Alexandra Winter <wintera@...ux.ibm.com>, 
	Thorsten Winkler <twinkler@...ux.ibm.com>, James Chapman <jchapman@...alix.com>, 
	Krzysztof Kozlowski <krzk@...nel.org>, Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
	Remi Denis-Courmont <courmisch@...il.com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
	Allison Henderson <allison.henderson@...cle.com>, Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, 
	Xin Long <lucien.xin@...il.com>, Wenjia Zhang <wenjia@...ux.ibm.com>, 
	Jan Karcher <jaka@...ux.ibm.com>, "D. Wythe" <alibuda@...ux.alibaba.com>, 
	Tony Lu <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>, Jon Maloy <jmaloy@...hat.com>, 
	Ying Xue <ying.xue@...driver.com>, Stefano Garzarella <sgarzare@...hat.com>, 
	Martin Schiller <ms@....tdt.de>, Kentaro Takeda <takedakn@...data.co.jp>, 
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, Paul Moore <paul@...l-moore.com>, 
	James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, 
	Guillaume Nault <gnault@...hat.com>, 
	Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz>, Andrew Morton <akpm@...ux-foundation.org>, 
	Wu Yunchuan <yunchuan@...china.com>, Max Gurtovoy <mgurtovoy@...dia.com>, 
	Maurizio Lombardi <mlombard@...hat.com>, David Howells <dhowells@...hat.com>, 
	Atte Heikkilä <atteh.mailbox@...il.com>, Vincent Duvert <vincent.ldev@...ert.net>, 
	Denis Kirjanov <kirjanov@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, 
	Arnd Bergmann <arnd@...db.de>, Thomas Huth <thuth@...hat.com>, 
	Andrew Waterman <waterman@...s.berkeley.edu>, Palmer Dabbelt <palmer@...belt.com>, 
	Andrej Shadura <andrew.shadura@...labora.co.uk>, Ying Hsu <yinghsu@...omium.org>, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, Tom Parkin <tparkin@...alix.com>, 
	Jason Xing <kernelxing@...cent.com>, Dan Carpenter <error27@...il.com>, Hyunwoo Kim <v4bel@...ori.io>, 
	Bernard Pidoux <f6bvp@...e.fr>, Sangsoo Lee <constant.lee@...sung.com>, 
	Doug Brown <doug@...morgal.com>, Ignat Korchagin <ignat@...udflare.com>, 
	Gou Hao <gouhao@...ontech.com>, Mina Almasry <almasrymina@...gle.com>, 
	Abhishek Chauhan <quic_abchauha@...cinc.com>, Yajun Deng <yajun.deng@...ux.dev>, Michal Luczaj <mhal@...x.co>, 
	Jiri Pirko <jiri@...nulli.us>, syzbot <syzkaller@...glegroups.com>, 
	linux-kernel@...r.kernel.org, kernel@...gutronix.de, linux-rdma@...r.kernel.org, 
	netdev@...r.kernel.org, linux-nvme@...ts.infradead.org, open-iscsi@...glegroups.com, 
	linux-scsi@...r.kernel.org, linux-arm-msm@...r.kernel.org, target-devel@...r.kernel.org, 
	gfs2@...ts.linux.dev, linux-nfs@...r.kernel.org, ocfs2-devel@...ts.linux.dev, 
	linux-cifs@...r.kernel.org, linux-hams@...r.kernel.org, linux-bluetooth@...r.kernel.org, 
	linux-can@...r.kernel.org, linux-s390@...r.kernel.org, rds-devel@....oracle.com, 
	linux-sctp@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, 
	virtualization@...ts.linux.dev, linux-x25@...r.kernel.org, linux-security-module@...r.kernel.org, 
	syzbot+d7ce59b06b3eb14fd218@...kaller.appspotmail.com, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] net: Convert proto_ops::getname to sockaddr_storage

On 16.12.2024 18:34:28, Kees Cook wrote:
> The proto_ops::getname callback was long ago backed by sockaddr_storage,
> but the replacement of it for sockaddr was never done. Plumb it through
> all the getname() callbacks, adjust prototypes, and fix casts.
> 
> There are a few cases where the backing object is _not_ a sockaddr_storage
> and converting it looks painful. In those cases, they use a cast to
> struct sockaddr_storage. They appear well bounds-checked, so the risk
> is no worse that we have currently.
> 
> Other casts to sockaddr are removed, though to avoid spilling this
> change into BPF (which becomes a much larger set of changes), cast the
> sockaddr_storage instances there to sockaddr for the time being.
> 
> In theory this could be split up into per-caller patches that add more
> casts that all later get removed, but it seemed like there are few
> enough callers that it seems feasible to do this in a single patch. Most
> conversions are mechanical, so review should be fairly easy. (Famous
> last words.)
> 
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
>  net/can/isotp.c                               |  3 +-
>  net/can/j1939/socket.c                        |  2 +-
>  net/can/raw.c                                 |  2 +-

Acked-by: Marc Kleine-Budde <mkl@...gutronix.de> # for net/can

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists